Skip to content

Make code more explicit #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2021
Merged

Make code more explicit #1467

merged 3 commits into from
Apr 29, 2021

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Apr 29, 2021 •
edited by andyleejordan
Loading

Adds small improvements to PSES that are made in #1459, but aren't related or really required for the main work there. The intent is to be able to rebase that work onto this.

andyleejordan
andyleejordan approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjmholt Can you rebase and remove "Merge branch 'master' into pses-fixes" (it's an empty commit so it should drop off no problem). Thanks for this PR! I think we'll probably find more to pull out as we work through reviewing the rest of #1459, but I am quite happy to do it piecemeal like this.

@andyleejordan andyleejordan added Area-Engine Issue-Enhancement A feature request (enhancement). labels Apr 29, 2021
@andyleejordan andyleejordan changed the title Add small improvements unrelated to main implementation in #1459 Make code more explicit Apr 29, 2021
@andyleejordan andyleejordan enabled auto-merge April 29, 2021 16:46
@andyleejordan andyleejordan merged commit feadcee into PowerShell:master Apr 29, 2021
@rjmholt
Copy link
Contributor Author

rjmholt commented Apr 29, 2021

The merge commit is something that GitHub generated for the Update Branch button. You may want to reconfigure the repository to not offer that or ideally use an alternate strategy if you wish to use merge commits for PR merges.

@rjmholt rjmholt deleted the pses-fixes branch April 29, 2021 17:21
@andyleejordan
Copy link
Member

Sadly I could not find that configuration option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees
No one assigned
Labels
Area-Engine Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjmholt @andyleejordan